Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RFC 0430 to allow underscores between numbers in CamelCase names #2478

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Update RFC 0430 to allow underscores between numbers in CamelCase names #2478

merged 1 commit into from
Jul 2, 2018

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Jun 16, 2018 •
edited
Loading

See rust-lang/rust#46907

Note: This is already implement and in stable (without RFC). It just updates the text to avoid confusion and to make this better known.

Found this while editing #2457.

@pyfisch
Copy link
Contributor Author

pyfisch commented Jun 16, 2018

cc @joshtriplett

Centril
Centril reviewed Jun 16, 2018
View reviewed changes
text/0430-finalizing-naming-conventions.md
@@ -46,6 +46,9 @@ precisely, the proposed (and mostly followed) conventions are:
In `UpperCamelCase`, acronyms count as one word: use `Uuid` rather than
`UUID`. In `snake_case`, acronyms are lower-cased: `is_xid_start`.

In `UpperCamelCase` names multiple numbers can be separated by a `_`
for clarity: `Windows10_1709` instead of `Windows101709`.

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Jun 16, 2018
@Centril
Copy link
Contributor

Centril commented Jun 16, 2018

This change seems like a no-brainer to me; all for it 👍

@joshtriplett
Copy link
Member

I think this is T-lang, not T-libs; it's about language naming conventions.

@joshtriplett joshtriplett added T-lang Relevant to the language team, which will review and decide on the RFC. I-nominated and removed T-libs-api Relevant to the library API team, which will review and decide on the RFC. labels Jun 21, 2018
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jun 21, 2018 •
edited
Loading

@rfcbot fcp merge

Seems like a simple and logical rule and it's already implemented. Let's do it.

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 21, 2018 •
edited by cramertj
Loading

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. labels Jun 21, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 22, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. and removed proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. labels Jun 22, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 2, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this RFC. and removed final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. labels Jul 2, 2018
@Centril Centril merged commit e978a8d into rust-lang:master Jul 2, 2018
@pyfisch pyfisch deleted the patch-1 branch July 2, 2018 19:49
@Centril Centril added A-formatting Proposals relating to formatting of Rust code. A-syntax Syntax related proposals & ideas and removed A-formatting Proposals relating to formatting of Rust code. labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees
No one assigned
Labels
A-syntax Syntax related proposals & ideas disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pyfisch @Centril @joshtriplett @nikomatsakis @rfcbot