-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Proposal to add methods to homogeneous tuples ((T, T, ..., T)
) so that they can be used as slices (&[T]
)
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
- Start Date: (fill me in with today's date, YYYY-MM-DD) | ||
- RFC PR #: (leave this empty) | ||
- Rust Issue #: (leave this empty) | ||
|
||
# Summary | ||
|
||
Add methods to allow homogeneous tuples (e.g., `(T, T, T)`) to be used | ||
as slices (`&[T]`). | ||
|
||
# Motivation | ||
|
||
Homogeneous tuples and fixed-length arrays have the same memory | ||
layout, but provide distinct capabilities. Tuples are particularly | ||
useful because they can be split apart into their componenet parts: | ||
|
||
let (a, b, c) = tuple; | ||
|
||
On the other hand, fixed-length arrays support indexing, which is | ||
great for writing generic code: | ||
|
||
for i in range(0, fixed_length.len()) { ... fixed_length[i] ... } | ||
|
||
I have found that in many cases I would prefer a tuple type, because I | ||
am managing a tuple of distinct cases that I would like to be able to | ||
destructor and reassign, but I would also sometimes like to use | ||
indexing to avoid code duplication. | ||
|
||
In this RFC, therefore, I augment tuple types with the ability to | ||
support indexing and in general act as slices. This means that tuples | ||
are a better choice than fixed-length arrays for those cases where one | ||
intends to pull apart the tuple at some point. | ||
|
||
# Detailed design | ||
|
||
Add the following traits for tuples of sizes 2 to 16 whose component | ||
type is `$T`: | ||
|
||
``` | ||
pub trait $Tuple<$T> { | ||
/// Number of elements in the tuple. | ||
fn len(&self) -> uint; | ||
|
||
/// A slice pointing onto the tuple. | ||
fn as_slice<'a>(&'a self) -> &'a [$T]; | ||
|
||
/// A mutable slice pointing onto the tuple. | ||
fn as_mut_slice<'a>(&'a mut self) -> &'a mut [$T]; | ||
|
||
/// Iterate through the elements of the tuple. | ||
fn iter<'a>(&'a self) -> Items<'a, $T>; | ||
|
||
/// Iterate through the elements of the tuple. | ||
fn mut_iter<'a>(&'a mut self) -> MutItems<'a, $T>; | ||
|
||
/// Index into the tuple. | ||
fn get<'a>(&'a self, index: uint) -> &'a $T; | ||
|
||
/// Index mutably into the tuple. | ||
fn get_mut<'a>(&'a mut self, index: uint) -> &'a mut $T; | ||
} | ||
``` | ||
|
||
The implementation of `as_slice` and `as_mut_slice` is done by simply | ||
creating a slice pair and transmuting. All other methods can be | ||
derived by invoking the appropriate method on the slice type. | ||
|
||
# Drawbacks | ||
|
||
None of which I am aware. | ||
|
||
# Alternatives | ||
|
||
1. Make fixed-length arrays a supertype of homogeneous tuples. More | ||
precisely, `(T_1, ..., T_n)` would be a subtype of `[U, ..n]` if | ||
`forall i. T_i <: U`. This is elegant but would be a deeper change | ||
for something that rarely comes up in practice. I am not sure of | ||
the full repercussions. I also don't think there's a big impact | ||
betwee this proposal and that one -- that is, if we added | ||
subtyping, these traits would presumably have little purpose, but | ||
we could just stop including them in the prelude and/or adapt | ||
somehow. | ||
|
||
2. As above, but use coercion. This is actually a somewhat smaller | ||
change though I am reluctant to do anything but tighten coercion | ||
rules for the time being. In particular I do not want to add ad-hoc | ||
rules because I hope to leave space for something more | ||
user-extensible in the future. In the event that these coercions | ||
become automatic, these tuple traits could probably be removed, or | ||
at least deprecated. | ||
|
||
3. Make fixed-length patterns more-expressive so that they can easily | ||
support moves. In other words, people might write: | ||
|
||
let [a, b, c] = fixed_length; | ||
|
||
instead of | ||
|
||
let (a, b, c) = tuple; | ||
|
||
This may be a good idea, and we do need to put some effort post-DST | ||
into rationalizing vector patterns, but is basically independent | ||
from this RFC. That is, doing this RFC doesn't preclude us from | ||
improving vector patterns, nor does it make it any harder. | ||
|
||
# Unresolved questions | ||
|
||
None. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the RFC as presented is fine, but this alternative really is more elegant. I'd prefer it if at all possible.