stabilize TcpStream::set_keepalive #1126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use. | ||
|
|
||
| Passing a `Duration` of zero would be equivalent to turning `SO_KEEPALIVE` off, | ||
| since no OS docs mention allowing a value of `0`. |
There was a problem hiding this comment.
The timeout RFC has been adjusted to use Option<Duration>, so this RFC should probably do that as well.
There was a problem hiding this comment.
Listed in Alternatives.
|
cc https://internals.rust-lang.org/t/pre-rfc-std-net-expansion-refinement/2079, a pre-RFC to take a comprehensive look at all of our socket options we have. |
nrc
added
the
T-libs-api
|
Thanks again for the RFC @seanmonstar, and sorry for taking awhile to get back to this! I've now opened an RFC to reconsider a large number of socket options as a whole, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize the
TcpSteram::set_keepalive()method asfn set_keepalive(&self, dur: Duration) -> io::Result<()>.Rendered