Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC to feature gate some slice patterns #164

Merged
merged 1 commit into from
Sep 3, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions active/0000-feature-gate-slice-pats.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
- Start Date: 2014-07-14
- RFC PR #: (leave this empty)
- Rust Issue #: (leave this empty)

# Summary

Rust's support for pattern matching on sices has grown steadily and incrementally without a lot of oversight,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "sices"

and we have concern that Rust is doing too much here, that the complexity is not worth it. This RFC proposes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is "we"? Is this the general opinion of the Mozilla employees? Is this your personal opinion?

to feature gate multiple-element slice matches in the head and middle positions (`[..xs, 0, 0]` and `[0, ..xs, 0]`.

# Motivation

Some general reasons and one specific: first, the implementation of Rust's match machinery is notoriously complex, and not well-loved. Remove features is seen as a valid way to reduce complexity. Second, slice matching in particular, is difficult to implement, while also being of only moderate utility (there are many types of collections - slices just happen to be built into the language). Finally, the exhaustiveness check is not correct for slice patterns - because of their complexity; it's not known that it
can be done correctly, nor whether it is worth the effort even if.

# Detailed design

The `advanced_slice_patterns` feature gate will be added. When the compiler encounters slice pattern matches in head or middle position it will emit a warning or error accourding to the current settings.

# Drawbacks

It removes two features that some people like.

# Alternatives

Fixing the exhaustiveness check would allow the feature to remain.

# Unresolved questions

N/A