Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in fn variance #1716

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Aug 15, 2016

Per #738 (comment)

I'm a little unsure though since this hasn't been fixed for so long?

@eddyb
Copy link
Member

eddyb commented Aug 15, 2016

cc @rust-lang/lang

@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 16, 2016
@aidanhs
Copy link
Member Author

aidanhs commented Aug 17, 2016

Finally, there can be cases where it is ok to make a lifetime longer, but not shorter. This comes up when the lifetime is used in a function return type (and only a fn return type).

By the same line of thought, I think this is wrong as well and should refer to function arguments?

I.e. it is safe to treat a fn(&'a T) as a fn(&'static T)

@nikomatsakis
Copy link
Contributor

Looks like a correct typo.

@nikomatsakis nikomatsakis merged commit efb139d into rust-lang:master Aug 18, 2016
@nikomatsakis
Copy link
Contributor

Er, a correct fix =)

@aidanhs aidanhs deleted the aphs-fn-variance branch August 19, 2016 15:06
@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants