Skip to content

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 23, 2014

No description provided.

@sinistersnare
Copy link

I don't think an RFC is needed for changes like this, at least until post 1.0 and post library stabilization.

std::iter is marked experimental, so people should expect changes like this.

More clarification is needed on what requires an RFC or not.

@pnkfelix
Copy link
Contributor

cc: rust-lang/rust#15886

@pnkfelix
Copy link
Contributor

This RFC was my fault; I gave @gankro bad advice on IRC, because I thought that the core team would probably prefer for changes to libcore to go through some sort of review. Telling @gankro to use the RFC process was probably a mistake. Maybe http://discuss.rust-lang.org would be a better forum for some initial discussion and/or resolution of outstanding questions.

@sinistersnare
Copy link

I agree with using Discourse instead of the RFC process for the final stages of the original pull request.

@Gankra
Copy link
Contributor Author

Gankra commented Jul 23, 2014

So to be clear, you guys are recommending I close this pull request, and just make a thread on discuss to the tune of "hey, is everyone cool with this thing I wrote"?

@sinistersnare
Copy link

@gankro I fully agree with that sentiment.

@Gankra
Copy link
Contributor Author

Gankra commented Jul 23, 2014

Works for me.

@Gankra Gankra closed this Jul 23, 2014
@Gankra
Copy link
Contributor Author

Gankra commented Jul 23, 2014

withoutboats pushed a commit to withoutboats/rfcs that referenced this pull request Jan 15, 2017
A `Builder` structure for CpuPool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants