Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Deprecate and later remove the in-tree url crate #189

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions active/0000-deprecate-url.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
- Start Date: 2014-07-29
- RFC PR #:
- Rust Issue #:

# Summary

Deprecate and later remove the in-tree url crate, in favor of rust-url.


# Motivation

This code [has](https://github.com/rust-lang/rust/issues/8486)
a [number](https://github.com/rust-lang/rust/issues/10705)
of [issues](https://github.com/rust-lang/rust/issues/10706)
that are [non-trivial](https://github.com/rust-lang/rust/issues/10707)
to fix incrementally.

[rust-url](http://servo.github.io/rust-url/) is a rewrite from scratch.
It can be used with Cargo.


# Detailed design

Replace `#![experimental]` with `#![deprecated]` in `src/liburl/lib.rs`.
([PR #16076](https://github.com/rust-lang/rust/pull/16076))

Later, after a deprecation cycle to be determined, remove `src/liburl` entirely.


# Drawbacks

Users will have to upgrade to a slightly different API.


# Alternatives

If someone wants to keep using the old code for some reason,
it could be extracted and put in a separate Cargo-enabled repository.


# Unresolved questions

How long should be the deprecation cycle?