-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish RFCs as mdbook to GitHub Pages. #2192
Conversation
Can see an example of it here: https://frewsxcv.github.io/rfcs/ Assuming this is desired, Travis just needs to be enabled (which I have permissions to turn on) and the GitHub 'personal access token' needs to be registered in the Travis settings (which I think I can also do). |
Spoke with someone at Rust Belt Rust who mentioned this idea (@mre 👋) and decided to take a stab at it. I originally implemented this upstream in the Rust source repository (by adding a git submodule and dynamically generating the contents of the book there). But then then I spoke with @steveklabnik and agreed that doing it in CI in this repository would be a lot easier.
5c0e33a
to
e6afcba
Compare
cc @rust-lang/docs |
I was holding off on suggesting this thinking it'd be a lot more work, so I'm +100 on this. |
Oh wow! That is awesome @frewsxcv. Thanks for that. ❤️ |
This is great! @rust-lang/core what do you think? I think merging this as-is is fine; but I'd also like to extend it someday; for example, we could map RFCs to section headings corresponding to year, etc. |
I'd pull the script out of Travis and into a separate file (could just be |
Seems fine by me! |
Done! |
Also, I take back what I said earlier. I do not have permissions to enable Travis CI for this repo, so someone else will have to do that for me. |
I have the power! I enabled travis, turned on "build only if .travis.yml is present" and turned off branch updates and PR updates, since this really only matters for master. Let me know if anything else should be changed! Love this btw!! |
cce8e2a
to
c3c92eb
Compare
We tested this out on a branch; deploying is using an ssh key that's added as a deploy key to this repo only and is encrypted in travis. The deploy worked! http://rust-lang.github.io/rfcs/ so this should start auto deploying when this gets merged to master! |
DID YOU EVER KNOOOOWWWW THAT I'M @frewsxcv'S HEEEEERROOOO |
Rust Belt Rust unconference discussion FOR THE WIN!!!!! (I was standing beside this conversation and got giddy about it just listening in and now here it is.) |
Spoke with someone at Rust Belt Rust who mentioned this idea (@mre 👋)
and decided to take a stab at it. I originally implemented this upstream
in the Rust source repository (by adding a git submodule and dynamically
generating the contents of the book there). But then then I spoke with
@steveklabnik and agreed that doing it in CI in this repository would be
a lot easier.