Amend RFC 1758 (repr(transparent)) w.r.t. repr(align) #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC made contradictory statements on whether repr(align(N)) can be combined with repr(transparent). [Discussion on the tracking issue][discuss] did not find a good reason to support it, so this commit makes the RFC internally consistent by prohibiting align(N) on transparent structs. [discuss]: rust-lang/rust#43036 (comment)
Centril
added
the
T-lang
|
@rkruppe -- just to check, this matches what we implemented too? |
|
Yes, rust-lang/rust#47158 reports an error if any other repr attribute is applied to a transparent struct. |
|
OK, I'm going to summarily merge. cc @rust-lang/lang |
Centril
added
A-repr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC made contradictory statements on whether repr(align(N)) can be combined with repr(transparent). Discussion on the tracking issue did not find a good reason to support it, so this commit makes the RFC internally consistent by prohibiting align(N) on transparent structs.