-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-RFC: Prior art #2333
Meta-RFC: Prior art #2333
Conversation
text/0000-prior-art.md
Outdated
need to explain the minutiae of the theoretical background. The finer details | ||
can instead be referred to the referred-to papers. | ||
|
||
## An improved historical record of Rust for posterity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think this is a great step. Kicking off core team review: @rfcbot fcp merge |
Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
I'd like the section to communicate that there are cases where Rust intentionally diverges from common or popular prior art. An example of this would be exceptions: Rust doesn't have them. In an RFC to add additional sugar to our |
👍 This section would have been badly needed back when this ? operator got added which now sadly means something completely different as in other languages. You should add as drawback however that a longer template makes it harder to contribute to the RFC process via writing an RFC as you now need to fill in more sections. It might also intimidate people who don't know many other languages and think they are expected to know a wide range of them otherwise their contribution is not welcome. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
@Centril sorry I should have said it earlier, but it is perfect. Thank you! |
The final comment period is now complete. |
Huzzah! The RFC is merged! Tracking issue: None, the RFC is self executing. |
(Should currently active RFC PRs also be updated to have a prior art section?) |
@glaebhoerl: I wouldn't say it is required for RFCs before the new format, but it would be nice, and reviewers can help with providing prior art where such is known. You could also create PRs against the PRs... =) |
🖼️ Rendered
📝 Summary
Adds a Prior art section to the RFC template where RFC authors may discuss the experience of other programming languages and their communities with respect to what is being proposed. This section may also discuss theoretical work such as papers.
💖 Thanks
My thanks to @ashleygwilliams for reviewing.
I'd also like to thank @nagisa for the neat section naming and
@scottmcm for giving me great critique which improved the RFC a lot.