Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Rebalancing Coherence #2451

Merged
merged 5 commits into from
Oct 28, 2018
Merged

Re-Rebalancing Coherence #2451

merged 5 commits into from
Oct 28, 2018

Commits on May 30, 2018

  1. Re-Rebalancing Coherence 

    RFC rust-lang#1023 introduced rules that exclude impls which should clearly be
valid. It also used some ambiguous language around what is a breaking
change, that ended up being completely ignored and contradicted by rust-lang#1105.
This RFC seeks to clarify what is or isn't a breaking change when it
comes to implementing an existing trait, and conservatively expands the
orphan rules to allow impls which do not violate coherence, and fit
within the original goals of rust-lang#1023.
    @sgrif
    sgrif committed May 30, 2018
    Configuration menu
    Copy the full SHA
    4c32c86 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Address feedback

    @sgrif
    sgrif committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    6be59ca View commit details
    Browse the repository at this point in the history

  2. typo

    @sgrif
    sgrif committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    8474222 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Fix nits

    @sgrif
    sgrif committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    f27e769 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. RFC 2451

    @Centril
    Centril authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    d533b8d View commit details
    Browse the repository at this point in the history