Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-RFC: Future possibilities #2561

Merged
merged 6 commits into from
Nov 1, 2018
Merged

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 11, 2018

🖼️ Rendered

📝 Summary

Adds a "Future possibilities" section to the 0000-template.md RFC template that asks authors to elaborate on what natural extensions there might to their RFC and what future directions this may take the project into. This section asks authors to think holistically.

💖 Thanks

To @aturon for a fruitful discussion about the evolution of the RFC process.

@Centril Centril added the T-core Relevant to the core team, which will review and decide on the RFC. label Oct 11, 2018
@aturon
Copy link
Member

aturon commented Oct 11, 2018

cc @rust-lang/core

@aturon
Copy link
Member

aturon commented Oct 11, 2018

I'm in favor of this addition; providing this context can indeed be very important. This may eventually be subsumed by a "staged RFC process", but I don't see harm in adding it to the template for the time being.

@Mark-Simulacrum
Copy link
Member

I agree that this change seems very reasonable.

One addition that I think could help resolve some if the concern over commentary specifically about future work might be to include an explicit sentence in the template that the future work section is not cause for acceptance of the current RFC or future RFCs; i.e. it provides information but does not have any benefits or downsides to said future work. I think being explicit about this could be quite helpful in the short-term.

@aturon
Copy link
Member

aturon commented Oct 11, 2018

@Mark-Simulacrum great point, fully agreed!

@Centril
Copy link
Contributor Author

Centril commented Oct 11, 2018

@Mark-Simulacrum Good idea; I added a paragraph; is that sort of along the lines you were thinking?

> Note that having something written down in the future-work section is not
> a reason to accept the current or a future RFC; such notes should be in the
> section on motivation or rationale in this or subsequent RFCs.
> The section merely provides additional information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty much exactly what I was thinking though I'd swap this and the next paragraph.

Ideally we'd indicate that this text is likely desirable to leave in the RFC (since it's both for authors and - perhaps even more so - for readers). I'm not sure how or if we should do that, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it around :)

My experience is that it isn't necessary (and it clutters the text) to keep the paragraph in the RFC since in the RFCs I wrote there was never too much unwarranted focus on the future work instead of what was actually proposed. However, if we notice it starts to become a problem, we can always change our minds later on and add a note to keep it.

@aturon
Copy link
Member

aturon commented Oct 17, 2018

OK, with these revisions in place, I'm going to go ahead and call for full review from the core team:

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Oct 17, 2018

Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. labels Oct 17, 2018
@nikomatsakis
Copy link
Contributor

@rfcbot fcp reviewed

I have some mixed feelings about this idea. On the one hand, I appreciate the arguments put forth in the RFC. I approve of authors thinking holistically, of course, and this may be a good way to encourage that.

On the other hand, I am nervous. It feels like having this section in the template implies that — if the RFC is accepted — there is a certain amount of "blessing" to the vision that is laid out in the future work. I am aware that the template offers a disclaimer, but that text will not appear in the final RFC. I might be happier if we titled the section "Future possibilities", or something like that, to help make the "speculative" nature of this section clear.

I think my concerns are already present in the RFC, in the text that worries about the possibility of "dickering" over the future work overshadowing or just adding on to the main RFC itself. I suppose that if @Centril claims this has not been true in practice I shouldn't worry much.

In general, my desire is still that we will move towards something more like the "staged RFC" process that I've proposed before. In that model, I imagine that "future work" would well be described by issues on the repository (probably with appropriate labels). It seems to me that this section could still be useful in that world, though, by proving links and perhaps a bit of context for the team that is not actively participating in that development.

@nikomatsakis
Copy link
Contributor

In case it wasn't clear, I decided "all in all" that I'm 👍 — if we want to rename to "Future possibilities" that seems good to me but I don't care to block on that.

@Centril
Copy link
Contributor Author

Centril commented Oct 22, 2018

Renamed the section to "Future possibilities" to make @nikomatsakis happier and to better reflect the speculative nature of the section's contents.

@Centril Centril changed the title Meta-RFC: Future work Meta-RFC: Future possibilities Oct 22, 2018
@rfcbot rfcbot added the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Oct 22, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Oct 22, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. label Oct 22, 2018
@diwic
Copy link

diwic commented Oct 24, 2018

how said proposals fit with the product vision and roadmap that the team currently has.

Do all teams have a product vision and roadmap, and if so, how do I find them?

@Centril
Copy link
Contributor Author

Centril commented Oct 24, 2018

@diwic

Do all teams have a product vision and roadmap, and if so, how do I find them?

For 2017, we had the "ergonomics initiative";
In 2018, we moved to "ship the things".
For 2019, we haven't decided yet and will start to brainstorm ideas soon.

Eventually, an RFC will be made that establishes the roadmap for the entire project for 2019.
You can read the last years roadmap here.

@aturon may be better equipped to elaborate on your question. :)

@diwic
Copy link

diwic commented Oct 24, 2018

@Centril Right, so that's a one-year over-all roadmap. Still lacking the vision as well as the subteam split, i e, reading the RFC it sounds like

  • every subteam has its own (one-year?) roadmap
  • every subteam has its own (multi-year?) vision

...and that, I have not found (yet), at least not in some kind of structured and easy-to-find fashion?

@Centril
Copy link
Contributor Author

Centril commented Oct 24, 2018

@diwic Yeah, the situation isn't ideal; I agree completely. I think for the language team we'll be brainstorming product visions soon, but I don't have anything solid to offer yet, sorry.

@diwic
Copy link

diwic commented Oct 24, 2018

@Centril no worries, I'm not demanding anything :-) While I agree that visions and roadmaps would be very nice to have, I was mostly confused by the wording of the RFC: It's hard to comply to a vision that is not defined.

@Centril
Copy link
Contributor Author

Centril commented Oct 24, 2018

@diwic Ah, hehe :) I think that wording can be ignored while there isn't a well defined roadmap / vision or you can just operate on the previously known roadmap / vision if there is any.

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this RFC. label Nov 1, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Nov 1, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot removed the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Nov 1, 2018
@Centril Centril merged commit 859b254 into rust-lang:master Nov 1, 2018
@Centril
Copy link
Contributor Author

Centril commented Nov 1, 2018

Huzzah! This RFC has been merged!

Tracking issue: Not available; The RFC is self-executing.

@Centril Centril deleted the rfc/future-work branch November 1, 2018 16:46
@Centril Centril added the A-meta Proposals about how we make proposals label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Proposals about how we make proposals disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-core Relevant to the core team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants