Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark RFC-3192 (aka the 'provide_any' feature) as rejected #3460

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

waynr
Copy link
Contributor

@waynr waynr commented Jul 19, 2023

This PR addresses the decision by the libs team not to proceed with the Provider trait and to merge what's left of RFC 3192 minus Provider (ie the Request aka Demand type) into the WIP RFC 2895.

For reference to these decisions, please see the following starting points:

Rendered

@waynr
Copy link
Contributor Author

waynr commented Jul 19, 2023

/cc @Amanieu @yaahc FYI, per our recent discussions around merging provide_any into error_generic_member_access.

@ehuss
Copy link
Contributor

ehuss commented Jul 20, 2023

Generally we don't remove RFCs when they are withdrawn. We don't have a formal mechanism for this, but it should be fine to add a notice towards the top explaining what has happened (example).

@ehuss ehuss added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Jul 20, 2023
@waynr
Copy link
Contributor Author

waynr commented Jul 20, 2023

Oh that's good to know and a good idea. I'll update this PR to add a similar notice. Thanks for the pointer!

@waynr waynr force-pushed the remove-rfc-3912 branch from 53f416a to 69a1519 Compare July 20, 2023 20:29
@waynr waynr changed the title remove RFC-3192, aka the 'provide_any' feature mark RFC-3192 (aka the 'provide_any' feature) as rejected Jul 20, 2023
@ehuss
Copy link
Contributor

ehuss commented Jul 23, 2023

cc @Amanieu, can you review/confirm this is what the libs team wants to say for the status of this RFC? Thanks!

@ehuss ehuss added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Jul 23, 2023
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this accurately summarizes the libs-api team decision from rust-lang/rust#96024 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants