Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: #[derive(SmartPointer)] #3621

Merged
merged 16 commits into from
Jul 11, 2024
Merged

RFC: #[derive(SmartPointer)] #3621

merged 16 commits into from
Jul 11, 2024

Commits on May 2, 2024

  1. RFC: #[derive(SmartPointer)] 

    Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
    @Darksonn @Veykril
    Darksonn and Veykril committed May 2, 2024
    Configuration menu
    Copy the full SHA
    061c786 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions by lqd

    @Darksonn
    Darksonn committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8a62c64 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Transparent containers implement both traits

    @Darksonn
    Darksonn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f775825 View commit details
    Browse the repository at this point in the history

  2. Fix typos

    @Darksonn
    Darksonn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8f029b2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Adjust how the macro expands trait bounds 

    Without this adjustment, it would not be possible to use this macro with
types such as the `ARef` type that was discussed on the RFC thread [1],
since we need `AlwaysRefcounted` to be specified for both T and U.

Link: https://www.github.com/rust-lang/rfcs/pull/3621#issuecomment-2094094231 [1]
    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    211abb3 View commit details
    Browse the repository at this point in the history

  2. Add #[smart_pointer::pointee]

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4cd0f76 View commit details
    Browse the repository at this point in the history

  3. Add drawback about trait name not matching

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    44e8727 View commit details
    Browse the repository at this point in the history

  4. Explain what the macro requires without reference to DispatchFromDyn

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    cd05ef2 View commit details
    Browse the repository at this point in the history

  5. Mention custom allocators in future possibilities

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    a9104e7 View commit details
    Browse the repository at this point in the history

  6. Add section on non-derive macros

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7f4e36b View commit details
    Browse the repository at this point in the history

  7. Also modify DispatchFromDyn for Pin

    @Darksonn
    Darksonn committed May 11, 2024
    Configuration menu
    Copy the full SHA
    1eec5b3 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Propose specific solution for Pin unsoundness issue

    @Darksonn
    Darksonn committed May 24, 2024
    Configuration menu
    Copy the full SHA
    17b4d18 View commit details
    Browse the repository at this point in the history

  2. Add unresolved concern about naming

    @Darksonn
    Darksonn committed May 24, 2024
    Configuration menu
    Copy the full SHA
    afe5534 View commit details
    Browse the repository at this point in the history

  3. Add missing link

    @Darksonn
    Darksonn committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5cfbde5 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Require #[repr(transparent)]

    @Darksonn
    Darksonn committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4fcfcca View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Remove details about how repr(transparent) constraint is implemented 

    And add #[repr(transparent)] to the examples.
    @Darksonn
    Darksonn committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    85ef575 View commit details
    Browse the repository at this point in the history