Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async closures #3668

Merged
merged 25 commits into from
Aug 3, 2024
Merged

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    80249c9 View commit details
    Browse the repository at this point in the history
  2. update numbers

    compiler-errors committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6000a0c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Clarify section about associated types being reserved

    We specify that the details about the traits, including the associated
    types, are implementation details.  Let's make the section describing
    this, with respect to the associated types, more clear and give an
    example.
    
    (Thanks to RalfJ and Yosh for raising that this section could be
    clarified.)
    traviscross committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a514d3b View commit details
    Browse the repository at this point in the history
  2. No perma

    compiler-errors committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d2446cb View commit details
    Browse the repository at this point in the history
  3. More clarifications

    compiler-errors committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    29582aa View commit details
    Browse the repository at this point in the history
  4. Add missing generics

    compiler-errors committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3938f65 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86fc14a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    90ea425 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    febff99 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    23b9af8 View commit details
    Browse the repository at this point in the history
  9. Oops, missing words

    compiler-errors committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    26ded68 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Update text/3668-async-closure.md

    Co-authored-by: Yosh <github@yosh.is>
    compiler-errors and yoshuawuyts authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b2a8e07 View commit details
    Browse the repository at this point in the history
  2. Fix hackmd-ism

    compiler-errors committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3298481 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88faa5b View commit details
    Browse the repository at this point in the history
  4. More writing

    compiler-errors committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    59e0eb2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    694d0df View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    2e35b78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    662654b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Update text/3668-async-closure.md

    whoops forgot a mut
    
    Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
    compiler-errors and zachs18 authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ee9b0cd View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. more nits

    compiler-errors committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3681ffd View commit details
    Browse the repository at this point in the history
  2. whoops

    compiler-errors committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f8c6e9f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Rename file for RFC 3668 to plural

    The feature gate for async closures is unfortunately in the singular,
    `async_closure`, and while that's not a stable commitment, it's
    probably too much of a pain to change that.  But that doesn't mean
    that we can't name the file in the plural, so let's do that.
    traviscross committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    186ce20 View commit details
    Browse the repository at this point in the history
  2. Add section about how AsyncFn commits us also

    As it turns out, `AsyncFn()` probably commits our direction on
    generalized `async` trait bound modifiers to the same degree as `async
    Fn()`.  Let's describe this.
    
    CE brought up this excellent point.
    traviscross committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    cb803f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    86ad484 View commit details
    Browse the repository at this point in the history
  2. Update text/3668-async-closures.md

    add the note in one other place
    
    Co-authored-by: Josh Triplett <josh@joshtriplett.org>
    compiler-errors and joshtriplett authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    576b9f4 View commit details
    Browse the repository at this point in the history