Revise file names and dir layout for issue 360 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit just: * combines the `complete/` and `active/` directories into one: `text/` * renames all of the RFC text files to use their earliest associated PR number as the RFC number. A follow-on commit encodes the `active`/`complete` distinction into a list in the README.md file, and fixes a few mistakes in the RFC files that I encountered along the way.
In particular: * The RFC associated with rust-lang#127 should have had a link to rust-lang#19 as well (and has been assigned RFC rust-lang#19); it also was revised to match the markdown href style of other RFCs. * RFC rust-lang#34 needed its header entries filled in, * RFC rust-lang#123 had a typo in its header, and * RC rust-lang#155 was revised to match the markdown href style of other RFCs.
Added a table-of-contents in the hopes that will ease navigation: the document now starts off with the active list after the introduction, so I anticipate that one will not see as much of the expository text as one used to, and thus the table of contents will help someone who is skimming to find their objective.
|
r? any core team member. The main things I'd like feedback on:
|
|
This all seems reasonable to me. |
|
@brson @alexcrichton hey did you want to take a look at this too? Or shall I just merge it? (If possible, I would like to resolve the PR before any other RFC PR's get merged, i.e. before the Tuesday mtg.) |
|
I was hoping to get some broader discussion on this before merging, and we can always be sure to merge this first before we merge anything else (we merge pretty rarely) |
|
@alexcrichton okay i will put this PR on the mtg agenda then. |
brson
added a commit
that referenced
this pull request
Oct 14, 2014
…ayout-for-issue-360 Revise file names and dir layout for issue 360
Centril
added
the
not-rfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can of course preview this new layout yourself by visiting: https://github.com/pnkfelix/rfcs/tree/fsk-revise-file-names-and-dir-layout-for-issue-360
See associated discussion from weekly meeting: https://github.com/rust-lang/meeting-minutes/blob/master/weekly-meetings/2014-10-07.md#how-to-link-to-rfcs
Fix #360.