-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use globs as RFC #867
use globs as RFC #867
Conversation
👍 Nit: "glob" refers to |
@sfackler I thought so, but the reference calls |
@seanmonstar Then I guess the reference is wrong, or at least slightly inaccurate with regard to naming. I think the reference might be using the term ‘glob’ in a slightly more general sense, referring to any sort of expansion done by shells (both |
+1 |
👍 |
+1, been bumping into this a lot recently. |
So, to be clear, the RFC proposed is not allowing Is that intentional? (It seems reasonable to allow it, but also reasonable to delay implementing such an extension, if for some reason its more difficult in the |
@pnkfelix that's actually in the Unresolved Questions section. I can see it being useful, but wasn't sure the consensus. |
@seanmonstar ah, right you are, sorry for the noise |
+1, I have wanted this. |
Thank you very much for your contribution! Clearly lots of people really like this idea. However, it is something we can add backwards compatibly after 1.0 ships (and it seems like we can continue getting by without it in the meantime). So, we are going to postpone this RFC (see issue #933), but hopefully will address it sometime after 1.0 ships. Thanks again |
@pnkfelix being postponed, would this mean accepted essentially? If I or someone else were to create a PR for 1.1, would that be accepted? |
@seanmonstar no, it means that a decision has been postponed. Post-1.0, you could open a new RFC PR or re-open this one. |
@nrc You said i could re-open this one? I don't believe I have permission to do so (I don't see the button), but if I were to open an new PR, it would be the same commit exactly... |
"re-open" means ask someone with the right privs to re-open for you, I guess (due to the GH security model, not Rust policy), but creating a new PR (like you've done) is totally fine. |
Related #1400 |
Allow aliasing imports when used in a glob import.
Rendered