This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Compile with newest rustc master #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should crawl the FS and use the default Clippy config file (e.g. clippy.toml)
|
I've been looking at this too. I don't think the right thing to do is to change the names of the tests - it is an error that Clippy is running at all on those tests. |
It seems that rustc doesn't handle `-Aclippy::all` and needs for the tool lint to be separated (`-A clippy::all`)
Xanewok
force-pushed
the
rustc-master
branch
from
311fbca
to
cf6358a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite recent Clippy bump in Rust, the current master doesn't compile because
clippy_lints::Confis private. Changed this toclippy_lints::read_conflike in clippy's analogous driver.rs.I believe this should detect clippy.toml on the filesystem level and the TODO comment can be removed @oli-obk @alexheretic
Will try to pull this in rust-lang/rust#53870 to see if RLS is fixed for the next nightlies.
cc @nrc