This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Collect input files for crates #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
commented
Nov 9, 2018
|
It'd be good to also update the input files while reusing the cached plan and also being able to tell if a recorded |
This allows it to bubble up to InitContextAction. This is required, because action handler ideally shouldn't have access to build internals and this is something that is updated in a lock-step between builds, so it seems like a good place to go.
Reverts change made in bdf0d92. There were some edge cases wrt relative/absolute paths and varying inputs cwd, so for now don't use the patch and rely on the old logic, instead.
Xanewok
force-pushed
the
crate-input-files
branch
from
361530c to
e2c8c28
Compare
|
Reverted the old dirty path heuristic and rebased, I think this should be good to go now. |
Xanewok
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1110.