-
Notifications
You must be signed in to change notification settings - Fork 256
Conversation
@h-michael Thanks for pointing out the unresolved conflict. That is fixed and pushed now. |
Thank you for the PR! Could you please rebase on top of the current master? This should fix the compilation errors (due to #1315, assuming Clippy didn't break again 😢 🤞 ) |
@Xanewok Sure. And sorry for the delay (busy couple of days). Hopefully all is fine with CI now... |
☔ The latest upstream changes (presumably #1320) made this pull request unmergeable. Please resolve the merge conflicts. |
@Xanewok Not sure why the previous commit failed CI. It looked like an error internal to clippy, perhaps? |
Various cosmetic improvements Closes #1314 (same PR + follow up test fixes).
Since that commit was based on this anyway, to reduce turnaround time I pushed a PR with your commits and the fixes on top of that. Thanks once again! |
@Xanewok No problem. And cheers for sorting out the text offsets! |
Related to the larger effort of rust-lang/rust#58036.