This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Cooperate with Cargo regarding target/ backup exclusion #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo excludes newly created target/ from backups[1]. This is an attempt to make rls interact nicely with it and prevent build directories like target/debug/ and target/release/ from polluting backups. The cargo dependency is updated to the latest cargo in order for the paths::create_dir_all_excluded_from_backups_atomic() function to become available to rls. [1] rust-lang/cargo#8378
|
I don't know what causes the build failure but when I run
on the current |
|
☔ The latest upstream changes (presumably #1689) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I don't think the |
|
Thanks, sorry this was laying for so long. |
|
Cheers, glad it landed in the end. Should I be concerned about those failed checks or are they unrelated to my change? |
|
They were unrelated 🙂 No worries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo excludes newly created target/ from backups[1]. This is an attempt
to make rls interact nicely with it and prevent build directories like
target/debug/ and target/release/ from polluting backups.
The cargo dependency is updated to the latest cargo in order for the
paths::create_dir_all_excluded_from_backups_atomic() function to become
available to rls.
[1] rust-lang/cargo#8378
Note: I'm not sure about many things here, like the test placement, the way to run rls in the test etc. so I followed some patterns I spotted in the code without deep understanding of what's going on, I'm happy to polish this to a desired state if I'm given some guidance.