This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
bump racer and rustfmt versions #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Sep 5, 2020
| rand = "0.7" | ||
| rayon = "1" | ||
| rustc_tools_util = "0.2" | ||
| rustfmt-nightly = { version = "1.4.20", git = "https://github.com/rust-lang/rustfmt", branch = "rustfmt-1.4.20" } | ||
| rustfmt-nightly = { version = "1.4.21", git = "https://github.com/rust-lang/rustfmt", branch = "rustfmt-1.4.21" } |
There was a problem hiding this comment.
I wanted to go ahead and open this so we could proceed if needed, though note this is still using the git reference
@topecongiro - any chance we could get rustfmt v1.4.21 published to crates.io (and v1.4.20 as well if you have time)
calebcartwright
commented
Sep 5, 2020
| @@ -4,7 +4,7 @@ steps: | |||
| set -e | |||
| curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain none | |||
| export PATH=$PATH:$HOME/.cargo/bin | |||
| rustup toolchain install $RUSTUP_TOOLCHAIN | |||
| rustup toolchain install $RUSTUP_TOOLCHAIN --force | |||
There was a problem hiding this comment.
Apparently there are already some components installed on the Azure Pipelines agents, so in cases where toolstates are broken (like now) rustup is dropping backing to the previous nightly which results in the rustc-ap-* crate compile failures
calebcartwright
force-pushed
the
racer-rustfmt-bump
branch
from
da0516f to
d9745da
Compare
|
Awesome, thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to addressing the current broken toolstates on nightly
rust-lang/rust#76145
rust-lang/rust#76146