This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Mark huge rls-analysis test data files as binary to filter greps #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a `git grep` (of rls or of rust-lang/rust with `--recurse-submodules`), if the grep happens to match within the huge rls-analysis test data files, the resulting multi-megabyte single-line can cause a text pager to grind to a halt and have trouble scrolling (especially scrolling backwards). These test data files are autogenerated and aren't formatted for human consumption, so mark them as binary, which causes `git grep` to instead just state that they match without printing the matching "line".
|
The CI failures seem to be entirely unrelated. |
|
Update: these json files seem to be triggering some major performance issues in |
|
Makes sense, thanks and sorry for the delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a
git grep(of rls or of rust-lang/rust with--recurse-submodules), if the grep happens to match within the hugerls-analysis test data files, the resulting multi-megabyte single-line
can cause a text pager to grind to a halt and have trouble scrolling
(especially scrolling backwards).
These test data files are autogenerated and aren't formatted for human
consumption, so mark them as binary, which causes
git grepto insteadjust state that they match without printing the matching "line".