Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Upgrade rls-{data,span} #285

Closed
wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link
Contributor

Additionally, lock racer version. The upstream started to fuck up interface.

Cargo has bumped the version and broke the compatibility. The code is updated accordingly (untested, hope it works).

We should really pin things to crates.io, with exception of rls related crates.

Additionally, lock racer version. The upstream started to fuck up ABI.
@nrc
Copy link
Member

nrc commented Apr 30, 2017

Thanks for the PR! The Racer version lock looks good, but we should not bump the other deps - there is a bit of an ongoing experiment there and we're not ready to use the newer versions in the RLS just yet.

@ishitatsuyuki
Copy link
Contributor Author

I have confirmed that the build passes and it should work as long as the modules are following semver.

@nrc
Copy link
Member

nrc commented May 1, 2017

Thanks for checking, but I would still rather not bump the versions until we know that is the direction we want to go in. There is also test failure here which may or may not be related.

@ishitatsuyuki
Copy link
Contributor Author

I'm going to close this as the new RLS crates needs porting. Instead, I will open another PR which simply upgrades (propers) dependencies, after rust-dev-tools/rls-vfs#15 is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants