This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Update clippy #768
Merged
Update clippy #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
That's true, I also thought this. But I suppose having the version in vcs is useful if you're checking out an old commit for use with an older compiler. I'm not sure if that matters to anyone in reality though. Either way it probably isn't a big deal. |
Closed
|
Agreed, I'm leaning a bit more towards keeping it in the file for the reason mentioned by @alexheretic. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wouldn't wildcard help here?
I mean if you want to build rls with clippy on latest nightly you (usually) have to use last version of clippy anyway.