This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Use Cargo to infer correct target/ build dir #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good! |
This was referenced Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730.
If the user did not specify the target dir in the configuration, this will infer this at the initialization and use what Cargo uses instead.
Eventually I think this should be used with
Inferrablestruct, just like with build_* - otherwise a sequence of setting an explicit target dir and 'unsetting' it in the configuration will not correctly run the inference later and it will continue to use the previously set dir.However, I'm opening it now so I can get more eyes on it and someone can try it out and see if it really works correctly.