Skip to content

Commit

Permalink
Merge #3092
Browse files Browse the repository at this point in the history
3092: vscode: fix binary is not functional on windows r=matklad a=Veetaha

This is my first approach to fix this error, need to double-check this on windows still...
Fixes #3087
Fixes #3090 

Co-authored-by: Veetaha <gerzoh1@gmail.com>
  • Loading branch information
bors[bot] and Veetaha authored Feb 11, 2020
2 parents 6ac871b + 78ee964 commit af9a9ab
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions editors/code/src/installation/download_file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ export async function downloadFile(
readBytes += chunk.length;
onProgress(readBytes, totalBytes);
})
.on("end", resolve)
.on("error", reject)
.pipe(fs.createWriteStream(destFilePath))
.pipe(fs.createWriteStream(destFilePath).on("close", resolve))
);
}

0 comments on commit af9a9ab

Please sign in to comment.