update rust-analyzer to new interned struct

rust-lang · Jan 24, 2025 · c762e4e · c762e4e
1 parent 1965cf0
commit c762e4e
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 23 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -135,7 +135,7 @@ process-wrap = { version = "8.0.2", features = ["std"] }
 pulldown-cmark-to-cmark = "10.0.4"
 pulldown-cmark = { version = "0.9.0", default-features = false }
 rayon = "1.8.0"
-salsa = { git = "https://github.com/davidbarsky/salsa.git", branch = "chayim-david-lukas/salsa-perf-improvements" }
+salsa = { git = "https://github.com/davidbarsky/salsa.git", branch = "chayim-david-lukas/salsa-changes-for-ra" }
 db-ext-macro = { git = "https://github.com/davidbarsky/db-ext-macro.git", rev = "c88f2f058ac4e6a8a09e87e41d7b30b147235514" }
 rustc-hash = "2.0.0"
 semver = "1.0.14"

diff --git a/crates/base-db/src/lib.rs b/crates/base-db/src/lib.rs
@@ -27,7 +27,7 @@ use vfs::{AbsPathBuf, FileId};
 #[macro_export]
 macro_rules! impl_intern_key {
     ($id:ident, $loc:ident) => {
-        #[salsa::interned_sans_lifetime(no_debug)]
+        #[salsa::interned(no_debug, no_lifetime)]
         pub struct $id {
             pub loc: $loc,
         }
@@ -167,7 +167,7 @@ impl Files {
     }
 }
 
-#[salsa::interned_sans_lifetime]
+#[salsa::interned(no_lifetime)]
 pub struct EditionedFileId {
     pub file_id: FileText,
     pub editioned_file_id: span::EditionedFileId,

diff --git a/crates/hir-def/src/lib.rs b/crates/hir-def/src/lib.rs
@@ -557,7 +557,7 @@ pub enum ItemContainerId {
 impl_from!(ModuleId for ItemContainerId);
 
 /// A Data Type
-#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum AdtId {
     StructId(StructId),
     UnionId(UnionId),
@@ -566,7 +566,7 @@ pub enum AdtId {
 impl_from!(StructId, UnionId, EnumId for AdtId);
 
 /// A macro
-#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum MacroId {
     Macro2Id(Macro2Id),
     MacroRulesId(MacroRulesId),
@@ -820,7 +820,7 @@ impl GeneralConstId {
 }
 
 /// The defs which have a body.
-#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum DefWithBodyId {
     FunctionId(FunctionId),
     StaticId(StaticId),
@@ -863,7 +863,7 @@ pub enum AssocItemId {
 // casting them, and somehow making the constructors private, which would be annoying.
 impl_from!(FunctionId, ConstId, TypeAliasId for AssocItemId);
 
-#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum GenericDefId {
     FunctionId(FunctionId),
     AdtId(AdtId),
@@ -946,7 +946,7 @@ impl From<AssocItemId> for GenericDefId {
     }
 }
 
-#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, PartialOrd, Ord, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum CallableDefId {
     FunctionId(FunctionId),
     StructId(StructId),
@@ -1062,7 +1062,7 @@ impl From<VariantId> for AttrDefId {
     }
 }
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum VariantId {
     EnumVariantId(EnumVariantId),
     StructId(StructId),

diff --git a/crates/hir-expand/src/db.rs b/crates/hir-expand/src/db.rs
@@ -152,7 +152,7 @@ pub trait ExpandDatabase: RootQueryDb {
     fn syntax_context(&self, file: HirFileId, edition: Edition) -> SyntaxContextId;
 }
 
-#[salsa::interned_sans_lifetime(id = span::MacroCallId)]
+#[salsa::interned(no_lifetime, id = span::MacroCallId)]
 pub struct MacroCallWrapper {
     pub loc: MacroCallLoc,
 }
@@ -168,7 +168,7 @@ fn lookup_intern_macro_call(db: &dyn ExpandDatabase, macro_call: MacroCallId) ->
         .clone()
 }
 
-#[salsa::interned_sans_lifetime(id = span::SyntaxContextId)]
+#[salsa::interned(no_lifetime, id = span::SyntaxContextId)]
 pub struct SyntaxContextWrapper {
     pub data: SyntaxContextId,
 }

diff --git a/crates/hir-ty/src/lower.rs b/crates/hir-ty/src/lower.rs
@@ -2463,7 +2463,7 @@ pub enum TyDefId {
 }
 impl_from!(BuiltinType, AdtId(StructId, EnumId, UnionId), TypeAliasId for TyDefId);
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, salsa::Enum)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, salsa::supertype)]
 pub enum ValueTyDefId {
     FunctionId(FunctionId),
     StructId(StructId),