Extra space before lifetime apostrophe in macro expansion

[tamaroning]

I try this code:

use std::marker::PhantomData;

struct Context<'cx> {
    phantom: PhantomData<&'cx ()>
}

macro_rules! trait_a {
    () => {
        trait A<'cx> {
            fn foo(&mut self, cx: &Context<'cx>);
        }       
    };
}

trait_a!();

struct S;

impl<'cx> A<'cx> for S {
    // Cursor is here
}

Rust analyzer completes the code as follow:

    fn foo(&mutself, cx: &Context< 'cx>) {
        
    }

I expected a completion like:

    fn foo(&mut self, cx: &Context<'cx>) {
        
    }

rust-analyzer version: (eg. output of "Rust Analyzer: Show RA Version" command)
rust-analyzer version: 5d5bbec 2022-05-09 stable

rustc version: (eg. output of rustc -V)
rustc 1.58.1 (db9d1b20b 2022-01-20)

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTUP_HOME or CARGO_HOME)
none

If this is not a complex issue, I would like to tackle with this.

[tamaroning]

@jhgg
There is also a needless whitespace prececding lifetime annotations.

[lnicola]

No, but we can't emit perfect code, and an extra space is harmless (it will get fixed on save/auto-format), as opposed to a missing one which causes rustfmt to fail.

After that PR, the completion is no longer "invalid".

[tamaroning]

@lnicola
I understand. thank you.

[jhgg]

@lnicola did you mean to re open this?

[lnicola]

Yeah, and repurpose it for the space @tamaroning asked about. It might be an easy fix, we can close it if not.

[tamaroning]

@lnicola
Okey.
I found another invalid completion related to this issue. Is it better to fix them in one PR?
Anyway I would like to fix an extra space before lifetime apostrophe.

use std::marker::PhantomData;

struct Context<'cx> {
    phantom: PhantomData<&'cx ()>
}

macro_rules! trait_a {
    () => {
        trait A<'cx, 'a> {
            fn foo(&mut self, cx: &'a Context<'cx>);
        }       
    };
}

trait_a!();

struct S;

impl<'cx, 'a> A<'cx, 'a> for S {
    // invalid completion (space is needed before Context)
    fn foo(&mutself, cx: & 'aContext< 'cx>) {
        
    }
}

[edwin0cheng]

I just checked, #12990 fixed all the issues mentioned here. So we could close it.