Log entries are not cleaned up when using "Restart server"

[hasali19]

I often use the "Restart server" command to reload rust analyzer when switching between build targets. I noticed that rust analyzer seems to create a new entry in the vscode output view every time the server is restarted. Is something not being cleaned up properly?

[Veykril]

Given you said you use this often and you are only reporting this now I assume this is a recent regression? And if that's the case are you using the nightly r-a? Wanna make sure whether this might be the request retry PR or not

Edit: Doesn't seem to a recent regression, latest stable triggers this as well so its not the rety PR (I also noticed sem highlighting erroring when restarting the server while its initializing)

[lnicola]

Not a regression, but make sure to disable tracing if you have it enabled.

[Veykril]

This also duplicates the rust analyzer language server log, not just the trace

[hasali19]

Given you said you use this often and you are only reporting this now I assume this is a recent regression? And if that's the case are you using the nightly r-a? Wanna make sure whether this might be the request retry PR or not

I use the restart command often, but I don't look at the logs very often so I only noticed it today. I am indeed using nightly.

Not a regression, but make sure to disable tracing if you have it enabled.

I disabled tracing which stops any output from being shown, but it seems that the entries in the menu are still duplicated.

[Veykril]

Ye it seems we don't dispose of/reuse the channels when restarting

[hasali19]

Tangentially, when changing the build target (rust-analyzer.cargo.target) vscode shows a notification that r-a needs to reload but the button reloads the whole window. That's kind of annoying so I've been manually using "Restart server" which works fine - it seems like the notification should also do that instead.

[Veykril]

Ye I think we can downgrade that to a server restart instead