Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor regression with null checkOnSave/target value #13660

Closed
iredelmeier opened this issue Nov 21, 2022 · 0 comments · Fixed by #13661
Closed

Minor regression with null checkOnSave/target value #13660

iredelmeier opened this issue Nov 21, 2022 · 0 comments · Fixed by #13661

Comments

@iredelmeier
Copy link
Contributor

rust-analyzer version: rust-analyzer 0.3.1293-standalone (2656297 2022-11-20)

rustc version: rustc 1.65.0 (897e37553 2022-11-02)

relevant settings: Reproduced in vim using with a brand new cargo new crate and coc-rust-analyzer < v0.69.6. I believe that v0.69.5 has the issue but that v0.69.6 handles it via this schema change.

#13290 changes the type of checkOnSave/target from an Option<String> to Vec<String>, and so any clients still setting it as null or failing to set it will run into problems. Setting it explicitly or defaulting to [] fixes it.

Not sure how much you care about config schema forwards compatibility. Apologies in advance if the expectation is that plugins are responsible for keeping up with breaking changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant