Fix: Handle empty checkOnSave/target values
#13661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This fixes a regression introduced by rust-lang#13290, in which failing to set `checkOnSave/target` (or `checkOnSave/targets`) would lead to an invalid config.
iredelmeier
force-pushed
the
fix-null-checkonsave-target
branch
from
00ece98 to
b116fe9
Compare
Contributor
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Contributor
|
Sorry 😞 thanks for catching it though ! |
arcnmx
added a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
The prior update included checkOnSave multiple targets: rust-lang/rust-analyzer#13290 but missed the fix for the regression it caused: rust-lang/rust-analyzer#13661 Merge commit '6d61be8e65ac0fd45eaf178e1f7a1ec6b582de1f'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #13290, in which failing to set
checkOnSave/target(orcheckOnSave/targets) would lead to an invalid config.[Fixes #13660]