Many break-outside-of-loop false negatives

[jplatte]

It looks like #14486, while it fixed type-mismatch errors, introduced a new kind of error on ?s inside async fnsinside closures or async blocks that occur within anasync fn`:

rust-analyzer version: 0.4.1465-standalone

rustc version: 1.69.0-beta.1 (b955c8271 2023-03-06)

relevant settings: -

cc @HKalbasi

[Veykril]

I am surprised we emit these here at all since they come from desugared things

[Veykril]

Does this happen for all your async functions? Are attributes involved? I can't reproduce htis with a simple

async fn f() {
    None::<()>.await?;
}

[jplatte]

Aha, yes attributes are involved in many places. Though I've also found some closures without attributes where this happens. It seems like both closures inside async fn and async blocks inside async fn (often from #[tracing::instrument]) are triggering this.

(first error disappears when removing instrument, all errors disappear when removing async before fn)

(error disappears when removing async before fn)