Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro brackets not colored in the latest version #16449

Closed
xhrnca00 opened this issue Jan 30, 2024 · 0 comments · Fixed by #16453
Closed

Macro brackets not colored in the latest version #16449

xhrnca00 opened this issue Jan 30, 2024 · 0 comments · Fixed by #16453
Assignees
@Veykril
Labels
C-bug Category: bug

Comments

@xhrnca00
Copy link

xhrnca00 commented Jan 30, 2024 •
edited
Loading

The macro brackets are not colored in the latest version.

rust-analyzer version: 0.3.1823-standalone (7219414 2024-01-27)
rustc version: (irrelevant)

relevant settings: VSCode, a new settings profile with default configuration, only rust-analyzer installed

Example:

#[cfg(not(target_os = "os"))]
fn main() {
    println!("Hello, world!");
}

This looks like this in the latest version (default theme):
image

Before the update (rust-analyzer version: 0.3.1815-standalone (d410d4a 2024-01-21)), it looked different:
image

Notice the highlighted outer bracket pair, which does not happen in the latest version.

I also tried the Pre-Release version of the extension (rust-analyzer version: 0.4.1824-standalone (d13951f 2024-01-29)), but there are no changes.
@xhrnca00 xhrnca00 added the C-bug Category: bug label Jan 30, 2024
@Veykril Veykril self-assigned this Jan 30, 2024
@Veykril Veykril mentioned this issue Jan 30, 2024
Merged
bors added a commit that referenced this issue Jan 30, 2024
@bors
Auto merge of #16453 - Veykril:brackets, r=Veykril
e68fe43 
internal: Undo special bracket classification for attributes in vscode config

I changed this thinking the `#` could be considered part of the bracket but on second though I don't think that's quite right in general.

Fixes #16449
@bors bors closed this as completed in 9a832c4 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal: Undo special bracket classification for attributes in vscode config Veykril/rust-analyzer
2 participants
@Veykril @xhrnca00