Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'0 implementations' on type nested in fn #3739

Closed
TyPR124 opened this issue Mar 27, 2020 · 4 comments · Fixed by #16812
Closed

'0 implementations' on type nested in fn #3739

TyPR124 opened this issue Mar 27, 2020 · 4 comments · Fixed by #16812
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@TyPR124
Copy link

TyPR124 commented Mar 27, 2020

I have the following:

#[derive(Clone)]
struct Foo;
fn bar() {
    #[derive(Clone)]
    struct Bar;
}

which shows '1 implementation' on Foo but '0 implementations' on Bar. I'm using version 0.2.100 as listed in VSCode.
@lnicola
Copy link
Member

lnicola commented Mar 27, 2020

Might be a duplicate of #1559.

@lnicola lnicola added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Jan 25, 2021
@lnicola
Copy link
Member

lnicola commented Jan 25, 2021

Blocked on #1559.

@bjorn3
Copy link
Member

bjorn3 commented Aug 27, 2021

#1559 has been fixed. Can someone confirm if this issue still exists?

@Veykril
Copy link
Member

Veykril commented Aug 27, 2021 •
edited
Loading

This seems to be an issue still
image

@lnicola lnicola added S-actionable Someone could pick this issue up and work on it right now and removed S-unactionable Issue requires feedback, design decisions or is blocked on other work labels Aug 28, 2021
@ShoyuVanilla ShoyuVanilla mentioned this issue Mar 11, 2024
Merged
@bors bors closed this as completed in e03df77 Mar 19, 2024
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Jul 16, 2024
@bors
Auto merge of rust-lang#3739 - joboet:macos_tls_dtors, r=RalfJung
50fb5d5 
Implement support for multiple TLS destructors on macOS

I want to get rid of [this `#[cfg]` block](https://github.com/rust-lang/rust/blob/98dcbae5c9ac615d5acfbf42d42b19a77cb9ec11/library/std/src/thread/mod.rs#L195-L211) in `std`, but it is currently required for miri, as it does not support multiple macOS TLS destructors. This is not true for the platform itself, however, as can be observed in the [implementation](https://github.com/apple-oss-distributions/dyld/blob/d552c40cd1de105f0ec95008e0e0c0972de43456/dyld/DyldRuntimeState.cpp#L2239).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Goto implementation to impls inside blocks ShoyuVanilla/rust-analyzer
4 participants
@lnicola @Veykril @bjorn3 @TyPR124