Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inferior completion suggesions (and what to do with them?) #3752

Closed
ngortheone opened this issue Mar 28, 2020 · 4 comments
Closed

Inferior completion suggesions (and what to do with them?) #3752

ngortheone opened this issue Mar 28, 2020 · 4 comments

Comments

@ngortheone
Copy link

Hi every so often I try use rust-analyzer. Right now my setup is vim with RLS and Clion with Rust plugin and I am really enthusiastic about rust analyzer.

Unfortunately completion suggestions are really poor. I am trying to understand whether there is something wrong with my rust-analyzer setup or completion suggestions are indeed not as good as I wish them to be.

Here is the same snippet of code with completion options on RLS(vim), rust-analyzer (both vscode and vim) and Clion with Rust plugin

Idea:

DeepinScreenshot_select-area_20200327225709

RLS(vim)

DeepinScreenshot_select-area_20200327225802

rust-analyzer (both vscode and vim have same completions suggestions)

DeepinScreenshot_select-area_20200327225734

Is there something I can do to get better suggestions?
Thanks.
@lnicola
Copy link
Member

lnicola commented Mar 28, 2020

There's nothing wrong with your setup. There are limitations regarding associated types: see #2603 and the others that end up pointing to rust-lang/chalk#234. Besides that, the impl Trait and dyn Trait support has been ripped out and is waiting for pending redesign in chalk.

@ngortheone
Copy link
Author

Thanks for prompt reply @lnicola ! I will be monitoring progress wrt to chalk

@lnicola
Copy link
Member

lnicola commented Mar 28, 2020

Let's close this for now and please report back if fixing chalk doesn't help.

@lnicola lnicola closed this as completed Mar 28, 2020
@flodiebold
Copy link
Member

Besides that, the impl Trait and dyn Trait support has been ripped out and is waiting for pending redesign in chalk.

That's incorrect, dyn Trait works and impl Trait only doesn't work in return position.

@lnicola lnicola mentioned this issue Mar 28, 2020
Closed
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Sep 25, 2024
@bors
Auto merge of rust-lang#3752 - Kixunil:simd-sha256, r=RalfJung
67c171e 
Implement SHA256 SIMD intrinsics on x86

Disclaimer: this is my first contribution to `miri`'s code. It's quite possible I'm missing something. This code works but may not be the cleanest/best possible.

It'd be useful to be able to verify code implementing SHA256 using SIMD since such code is a bit more complicated and at some points requires use of pointers. Until now `miri` didn't support x86 SHA256 intrinsics. This commit implements them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lnicola @flodiebold @ngortheone