Wrong color of ? operator in face of hints

[schungx]

Not sure if anybody raised this before...

When chaining, and one of the parts ends with an ? operator, the hint's color bleeds into the ?, like the following:

Don't worry about the actual color (which is a faint grey) because I just set it this way.

In this example, the ? at the end of the chaining line should be colored regular, instead of as a hint.

[lnicola]

Does it still happen if you disable ligatures? Or at least the ?: one, which doesn't make sense as Rust syntax.

[schungx]

You're right! The problem is font ligatures! I use Fira Code Retina.

Not sure whether I can selectively disable ?: in VS code, but true enough, disabling font ligatures solves the problem!

I suggest maybe putting a space in front of : in hints to avoid getting trapped with ligatures?

[lnicola]

I think you can, the Fira Code readme describes how each of them is called.

[lnicola]

Sorry, I was thinking of https://github.com/tonsky/FiraCode/blob/master/extras/stylistic_sets.png, but there seems to be no alternative for that one.

[schungx]

Putting a space in front of the colon (or omit it completely if the colors are different enough from text) is a possible solution... I am not sure how many different ligatures end with :, so this may be worth considering.

[lnicola]

I filed tonsky/FiraCode#1140 just in case, but I think a space or ZWNJ will work. Even if it's implemented, we should do that to support other fonts.

[lnicola]

Strangely, I don't see the same effect (though that :: looks so derpy):

[schungx]

That's weird... perhaps you're using a font without ?: ligature? I believe ?: is not very common...

[lnicola]

No, it's Fira Code 5.2. Maybe it was removed at some point? I couldn't find any reference to it in the changelog.

[schungx]

I have a really old version of Fira Code, version 1.204. Let me install the latest version to check...

[lnicola]

It was removed in https://github.com/tonsky/FiraCode/blob/master/CHANGELOG.md#30-april-9-2020, I don't know why I couldn't find it before.

[schungx]

OK, confirmed. The latest version of Fira Code no longer has this problem! Good catch!!!

Unfortunately, JetBrains Mono still has it...

[lnicola]

Can you test #6236?

[schungx]

Hhhmmm... don't know how to install a custom build of ra... I just load it from the the official extensions.

My suggestion is to add the JetBrains Mono font. The latest version should still have ?:.

Source Code Pro also doesn't have ?:, so right now the only recent version popular font that has it will be JetBrains Mono...

[lnicola]

My suggestion is to add the JetBrains Mono font.

I find building the extension easier than installing fonts on Linux 😅.

Does this work?

[schungx]

I find building the extension easier than installing fonts on Linux 😅.

That's why you're DA MAN!

Does this work?

Your picture looks just fine!

[schungx]

Just for future reference, ?: also seems to conflict with TypeScript:

tonsky/FiraCode#970