Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering Issue #1 #7325

Closed
1 of 4 tasks
matklad opened this issue Jan 18, 2021 · 1 comment
Closed
1 of 4 tasks

Steering Issue #1 #7325

matklad opened this issue Jan 18, 2021 · 1 comment
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@matklad
Copy link
Member

matklad commented Jan 18, 2021

This the steering issue -- it documents our roadmap for the next six weeks!

Steering meeting: link

The overall theme of the sprint is end-user experience. Specific subissues:

@matklad matklad pinned this issue Jan 18, 2021
bors bot added a commit that referenced this issue Jan 18, 2021
7336: Rename `CrateDefMap` to `DefMap` r=matklad a=jonas-schievink

I propose handling local items by computing a `DefMap` for every block expression, using the regular (early) name resolution algorithm. The result of that will be a `DefMap` that has a reference to the parent `DefMap`, which is either the one computed for the containing block expression, or the crate's root `DefMap`. Name resolution will fall back to a name in the parent `DefMap` if it cannot be resolved in the inner block.

The `DefMap`s computed for block expressions will go through a separate query that can be garbage-collected much more aggressively, since these `DefMap`s should be cheap to compute and are never part of a crate's public API.

The first step towards that is to make `CrateDefMap` not specific to crates anymore, hence this rename (if this plans sounds reasonable).

cc #7325 and #1165

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 22, 2021
@matklad
Copy link
Member Author

matklad commented Mar 1, 2021

We didn't ticked the boxes, but we made a great progress.

Understandably, actually ticking the boxes turns out to be challenging. To get better at these, we decided to officially install @matklad as "cheif makes-sure-that-the-boxes-are-ticked officer" for the next cycle.

@matklad matklad closed this as completed Mar 1, 2021
@matklad matklad unpinned this issue Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

2 participants