Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Edition 2021 support #9056

Closed
4 of 5 tasks
jonas-schievink opened this issue May 29, 2021 · 1 comment
Closed
4 of 5 tasks

Tracking issue for Edition 2021 support #9056

jonas-schievink opened this issue May 29, 2021 · 1 comment
Labels
C-support Category: support questions S-actionable Someone could pick this issue up and work on it right now

Comments

@jonas-schievink
Copy link
Contributor

jonas-schievink commented May 29, 2021 •
edited by Veykril
Loading

This is a list of 2021 edition changes that require rust-analyzer support. The list is taken from the official blog post https://blog.rust-lang.org/2021/05/11/edition-2021.html.
@m-ou-se
Copy link
Member

m-ou-se commented May 31, 2021

Edition-dependent prelude (not fully implemented upstream: rust-lang/rust#85687)

Note that the three std::prelude::rust_* modules already exist and the right one is already selected based on the edition. So, rust-analyzer could already implement picking the right prelude. It's just that right now all three of these modules have identical contents, until that PR is merged.

@jonas-schievink jonas-schievink mentioned this issue Jun 1, 2021
Merged
bors bot added a commit that referenced this issue Jun 1, 2021
@bors @jonas-schievink
Merge #9097
4f63e79 
9097: feat: Implement per-edition preludes r=jonas-schievink a=jonas-schievink

Part of #9056

Our previous implementation was incorrect (presumably because of the misleading comment in libstd [here](https://github.com/rust-lang/rust/blob/a7890c7952bdc9445eb6c63dc671fa7a1ab0260d/library/std/src/lib.rs#L339-L343)). `#[prelude_import]` does not define the prelude, it can only override the implicit prelude for the current crate.

This PR fixes that, which also makes the prelude imports in `rustc_span` work. Closes #8815.

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
This was referenced Jun 1, 2021
Merged
Closed
bors bot added a commit that referenced this issue Jun 3, 2021
@bors @jonas-schievink
Merge #9104
c7eb19e 
9104: Implement `#[rustc_skip_array_during_method_dispatch]` r=flodiebold a=jonas-schievink

haxx run the world

Closes #8552
Part of #9056

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@m-ou-se m-ou-se mentioned this issue Sep 3, 2021
Closed
@unageek unageek mentioned this issue Dec 3, 2021
Open
37 tasks
@Veykril Veykril added C-support Category: support questions S-actionable Someone could pick this issue up and work on it right now labels May 28, 2022
@Veykril Veykril closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-support Category: support questions S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-ou-se @jonas-schievink @Veykril