Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting exit points only works on return in VSCode #9395

Open
Veykril opened this issue Jun 24, 2021 · 0 comments
Open

Highlighting exit points only works on return in VSCode #9395

Veykril opened this issue Jun 24, 2021 · 0 comments
Labels
A-vscode vscode plugin issues C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@Veykril
Copy link
Member

Veykril commented Jun 24, 2021 •
edited
Loading

Companion issue to microsoft/vscode#127007 to keep track of the issue on our side.

Basically exit point highlighting is supposed to work when the cursor is either on a return, ? or -> token but VSCode currently doesn't send the document highlight request unless the cursor is on a return or at the end of an identifier followed by a ?.

cc #9375
@Veykril Veykril added A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work labels Jun 24, 2021
@Veykril Veykril added the C-bug Category: bug label Apr 9, 2023
@Veykril Veykril mentioned this issue May 2, 2023
Merged
bors added a commit that referenced this issue May 2, 2023
@bors
Auto merge of #14711 - Veykril:highlight-captures, r=Veykril
1ad58a4 
feat: Highlight closure captures when cursor is on pipe or move keyword

This runs into the same issue on vscode as exit points for `->`, where highlights are only triggered on identifiers, #9395

Though putting the cursor on `move` should at least work.
@Veykril Veykril mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vscode vscode plugin issues C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Veykril