Array inference #1103
Merged
Array inference #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Apr 4, 2019
Lapz
commented
Apr 4, 2019
matklad
reviewed
Apr 5, 2019
matklad
reviewed
Apr 5, 2019
flodiebold
approved these changes
Apr 5, 2019
flodiebold
reviewed
Apr 7, 2019
| @@ -17,8 +17,8 @@ pub use self::{ | |||
| generated::*, | |||
| traits::*, | |||
| tokens::*, | |||
| extensions::{PathSegmentKind, StructKind, FieldKind, SelfParamKind}, | |||
There was a problem hiding this comment.
looks like you removed this use, probably while rebasing, that's why it's currently not building
changed the display for fixed array types, Added Array Enum to ra_hir/expr
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2019
1103: Array inference r=flodiebold a=Lapz Fixes the final item in #394. The only problem is that infering the repeat cause some types to be infered twices. i.e ```rust fn test() { let y = unknown; [y, &y]; } ``` results in the following diff: ```diff [11; 48) '{ ...&y]; }': () [21; 22) 'y': &{unknown} [25; 32) 'unknown': &{unknown} -[38; 45) '[y, &y]': [&&{unknown}] +[38; 45) '[y, &y]': [&&{unknown};usize] [39; 40) 'y': &{unknown} +[39; 40) 'y': &{unknown} [42; 44) '&y': &&{unknown} [43; 44) 'y': &{unknown} ``` Should the code produce two inference results for 'y' and if not could any tell me what needs to change. Co-authored-by: Lenard Pratt <l3np27@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the final item in #394. The only problem is that infering the repeat cause some types to be infered twices.
i.e
results in the following diff:
[11; 48) '{ ...&y]; }': () [21; 22) 'y': &{unknown} [25; 32) 'unknown': &{unknown} -[38; 45) '[y, &y]': [&&{unknown}] +[38; 45) '[y, &y]': [&&{unknown};usize] [39; 40) 'y': &{unknown} +[39; 40) 'y': &{unknown} [42; 44) '&y': &&{unknown} [43; 44) 'y': &{unknown}Should the code produce two inference results for 'y' and if not could any tell me what needs to change.