Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code/inlay): hide hints when selected by cursor #11491

Conversation

saiintbrisson
Copy link
Contributor

@saiintbrisson saiintbrisson commented Feb 18, 2022

This PR closes #5903 (after almost a year 🥳, #5903 (comment)). You can enable the function to disable inlay hints inside text selections by setting rust-analyzer.inlayHints.hideWhenSelected to true.

image

@lnicola
Copy link
Member

lnicola commented Feb 18, 2022

Oof, CC #11445.

@saiintbrisson
Copy link
Contributor Author

Oh, that's unfortunate! Thank you for the heads up, should I close this?

@SomeoneToIgnore
Copy link
Contributor

should I close this

Nobody knows for sure, I guess.

I would expect some people disappointed by the way the new hints work (see comments to the PR linked above), so we might keep our impl for a little longer?
Or not, if those issues are fixed or not that many people will actually care about the change.

But definitely it would be more beneficial to have less code to maintain ourselves, so we will abandon this code eventually.
First abandonment attempt will happen really soon (in the next Code version?), according to microsoft/vscode#16221 (comment)
So in perspective, this PR won't be used in the project at all and it might make sense to close it.

@saiintbrisson
Copy link
Contributor Author

Will do, guess I should've done it sooner, but that's on me. Thank you anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: option to disable inlay hints on lines with an active cursor
3 participants