feature: add a "Add attribute" assist #12296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit cb135ae has been approved by |
|
☀️ Test successful - checks-actions |
|
Hm, not entirely sure it's a good idea :) "add derive" is something I use very frequently, and this adds an extra step to that. I'd probably leave |
|
Yeah, this assist doesn't currently work that well. I'll probably revert it. |
jonas-schievink
changed the title
jonas-schievink
changed the title
bors
added a commit
that referenced
this pull request
May 20, 2022
feat: Revert the "Add attribute" assist Reverts #12296, as the added indirection and "assist noise" (the assist has to trigger inside the body of an item to match what the "Add `#[derive]`" does) makes this not really pull its weight over just using attribute completions. Keeps the changes to "Add getter". `#[must_use]` can be applied using the attribute completions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the "Add
#[derive]" assist and supports adding#[must_use]and#[inline].Removes
#[must_use]from the "Generate getter/setter" assist, addressing the last point in #12273. Closes #12273.