fix: Fix completions disappearing when typing two keys in quick succession #12431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
changed the title
Veykril
force-pushed
the
request-retry
branch
2 times, most recently
from
d03b6af to
3354988
Compare
|
r? @matklad |
matklad
reviewed
May 31, 2022
matklad
reviewed
May 31, 2022
|
@bors r+ |
|
📌 Commit d88ae66 has been approved by |
|
☀️ Test successful - checks-actions |
|
I'm not familiar with the r-a release cycle, how long might this take to land in the VSCode extension? |
|
next monday for the stable release, tomorrow (~4hrs) for the nightly one |
|
@0x5c five days, or you can install a pre-release version tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we now retry requests if they get cancelled due to document changes.
This fixes the completions problem we have where completions seem to randomly disappear, see https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Completions.20not.20always.20appearing
Fixes #10187
Fixes #7560
Fixes #12153