Skip to content

fix: Fix trait impl completions using wrong insert position #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Jun 5, 2022
Merged

fix: Fix trait impl completions using wrong insert position #12475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion crates/ide-completion/src/completions/item_list/trait_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ fn completion_match(ctx: &CompletionContext) -> Option<(ImplCompletionKind, Text
ImplCompletionKind::All,
match nameref {
Some(name) => name.syntax().text_range(),
None => TextRange::empty(ctx.position.offset),
None => ctx.source_range(),
},
ctx.impl_def.clone()?,
)),
Expand Down Expand Up @@ -688,6 +688,27 @@ trait Test {
type SomeType;
}
impl Test for () {
type SomeType = $0;\n\
}
",
);
check_edit(
"type SomeType",
r#"
trait Test {
type SomeType;
}
impl Test for () {
type$0
}
"#,
"
trait Test {
type SomeType;
}
impl Test for () {
type SomeType = $0;\n\
}
Expand Down