Skip to content

show current function in analysis-stats progress bar #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019
Merged

show current function in analysis-stats progress bar #1273

merged 1 commit into from
May 14, 2019

Conversation

matklad
Copy link
Member

@matklad matklad commented May 14, 2019

No description provided.

@matklad
Copy link
Member Author

matklad commented May 14, 2019

bors r+
🤖

bors bot added a commit that referenced this pull request May 14, 2019
1273: show current function in analysis-stats progress bar r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 14, 2019

Build succeeded

@bors bors bot merged commit d4b1e95 into master May 14, 2019
@bors bors bot deleted the bar branch May 14, 2019 07:08
@flodiebold
Copy link
Member

The problem with this, and the reason why I didn't do this, is that the progress bar is not updated every time, so if it crashes, the function in the progress message is usually not the one where it crashed :(

@edwin0cheng
Copy link
Member

May i miss something, why the progress bar is not updated every time when set_message is called ?

@matklad
Copy link
Member Author

matklad commented May 20, 2019

Argh, indicatiff API are really confusing... Should be fixed in #1288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants