Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolve derive helper attributes in IDE layer #12864

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jul 24, 2022

image

Also downmaps tokens inside deriver helpers to the derive expansion
image

This does not handle the case where multiple derives make use of the same helper name though, unsure how to tackle that yet.

Partially addresses #10935

@Veykril Veykril changed the title feat: Downmap tokens inside derive helpers feat: Record derive helper attributes, resolve them in IDE layer Jul 24, 2022
@Veykril Veykril changed the title feat: Record derive helper attributes, resolve them in IDE layer feat: Resolve derive helper attributes in IDE layer Jul 24, 2022
@bors
Copy link
Contributor

bors commented Jul 25, 2022

☔ The latest upstream changes (presumably #12871) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril marked this pull request as ready for review July 26, 2022 07:27
@Veykril
Copy link
Member Author

Veykril commented Jul 26, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit ddad284 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 26, 2022

⌛ Testing commit ddad284 with merge e36a20c...

@bors
Copy link
Contributor

bors commented Jul 26, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e36a20c to master...

@bors bors merged commit e36a20c into rust-lang:master Jul 26, 2022
@Veykril Veykril deleted the derive-helpers branch July 26, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants