fix: Avoid error popup when using in Live Share #13095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
commented
Aug 24, 2022
| @@ -33,7 +33,7 @@ export function outputChannel() { | |||
| } | |||
|
|
|||
| export interface RustAnalyzerExtensionApi { | |||
| client: lc.LanguageClient; | |||
| client?: lc.LanguageClient; | |||
There was a problem hiding this comment.
This is public API but I am not sure how we're supposed to version it.
There was a problem hiding this comment.
Well our versioning story is a bit awkward anyways in that 0.4 is nightly and 0.3 is stable. So minor version bumps don't really make sense for API stability either
There was a problem hiding this comment.
Since node uses standard semver anyways, I think every version we publish can include breaking changes, so we should be fine?
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #8844
Not sure if there's a better way to do this, feedback appreciated!