internal: Refactor language client handling #13426
Conversation
Veykril
force-pushed
the
client-refactor
branch
from
39a42d4 to
6f43597
Compare
|
Stop and start server commands are implemented now. For some reason disposing a language client doesn't properly get rid of it in VSCode, so by constantly restarting the server via the reload/start commands one will slowly leak memory 🎉 At this point I don't wanna question the VSCode internals anymore though. Ideally we would never dispose the client, but that's not an option as we want to change the server path and initialization options between restarts, neither of which is supported... |
Veykril
force-pushed
the
client-refactor
branch
from
e289a24 to
0421756
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Veykril
changed the title
Follow up to #12847 (turns out they fixed parts of the problem)
The PR will attempt to allow us to dispose more resources at will, so that we can implement restarts for the server properly instead of restating the entire extension as well as allowing us to implement a stop command.
Closes #12936
Closes #4697