internal: Use a process group for flycheck #13552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Nov 5, 2022
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Veykril
commented
Nov 14, 2022
| @@ -359,6 +360,8 @@ impl FlycheckActor { | |||
| } | |||
| } | |||
|
|
|||
| struct JodChild(GroupChild); | |||
There was a problem hiding this comment.
I just realized I forgot to implement Drop for this 😶 (shouldn't really matter fortunately)
nielx
added a commit
to nielx/rust-analyzer
that referenced
this pull request
Jan 15, 2023
With rust-lang#13552 the depencency of on the command-group crate was introduced, which also introduced a dependency on nix. That version of nix does not build on Haiku. This change introduces a newer version of command-group, which also updates nix from 0.22.3 to 0.26.1, which is compatible on Haiku.
bors
added a commit
that referenced
this pull request
Jan 15, 2023
Update command-group from 1.0.8 to 2.0.1 With #13552 the depencency of on the command-group crate was introduced, which also introduced a dependency on nix. That version of nix does not build on Haiku. This change introduces a newer version of command-group, which also updates nix from 0.22.3 to 0.26.1, which is compatible on Haiku.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #13348